Skip to content

Fix mypy issues in tests.extra - #1360

Merged
bact merged 1 commit into
PyThaiNLP:devfrom
bact:fix-mypy-test
Mar 23, 2026
Merged

Fix mypy issues in tests.extra#1360
bact merged 1 commit into
PyThaiNLP:devfrom
bact:fix-mypy-test

Conversation

@bact

@bact bact commented Mar 23, 2026

Copy link
Copy Markdown
Member

What was wrong

mypy errors in tests.extra

  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case labels Mar 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@bact bact added this to PyThaiNLP Mar 23, 2026
@bact bact added this to the 5.3.3 milestone Mar 23, 2026
@bact bact moved this to In progress in PyThaiNLP Mar 23, 2026
@bact
bact merged commit 48ddbee into PyThaiNLP:dev Mar 23, 2026
25 of 26 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in PyThaiNLP Mar 23, 2026
@bact
bact deleted the fix-mypy-test branch March 23, 2026 12:16
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 66.413% (-0.01%) from 66.423%
when pulling f8b5bd1 on bact:fix-mypy-test
into edffd4a on PyThaiNLP:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants